[PATCH] Convert fs/nfsctl.c to use C99 named initiailzers

• Next message: Art Haas: "[PATCH] C99 initializer for arch/i386/kernel/setup.c"
• Previous message: Art Haas: "[PATCH] Add small C99 named initializers to fs/bio.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi.

The following patch converts the file to use C99 named initializers.
These change make the file compile with fewer warnings if '-W' is added
to the compile flags, and may enhance code readability. Let me know if
you think this should be sent to Linus.

Art Haas

===== fs/nfsctl.c 1.5 vs edited =====
--- 1.5/fs/nfsctl.c Sun Jan 5 17:19:30 2003
+++ edited/fs/nfsctl.c Tue Feb 11 09:38:42 2003
@@ -54,13 +54,36 @@
 static struct {
         char *name; int wsize; int rsize;
 } map[] = {
- [NFSCTL_SVC]={".svc", sizeof(struct nfsctl_svc)},
- [NFSCTL_ADDCLIENT]={".add", sizeof(struct nfsctl_client)},
- [NFSCTL_DELCLIENT]={".del", sizeof(struct nfsctl_client)},
- [NFSCTL_EXPORT]={".export", sizeof(struct nfsctl_export)},
- [NFSCTL_UNEXPORT]={".unexport", sizeof(struct nfsctl_export)},
- [NFSCTL_GETFD]={".getfd", sizeof(struct nfsctl_fdparm), NFS_FHSIZE},
- [NFSCTL_GETFS]={".getfs", sizeof(struct nfsctl_fsparm), sizeof(struct knfsd_fh)},
+ [NFSCTL_SVC] = {
+ .name = ".svc",
+ .wsize = sizeof(struct nfsctl_svc)
+ },
+ [NFSCTL_ADDCLIENT] = {
+ .name = ".add",
+ .wsize = sizeof(struct nfsctl_client)
+ },
+ [NFSCTL_DELCLIENT] = {
+ .name = ".del",
+ .wsize = sizeof(struct nfsctl_client)
+ },
+ [NFSCTL_EXPORT] = {
+ .name = ".export",
+ .wsize = sizeof(struct nfsctl_export)
+ },
+ [NFSCTL_UNEXPORT] = {
+ .name = ".unexport",
+ .wsize = sizeof(struct nfsctl_export)
+ },
+ [NFSCTL_GETFD] = {
+ .name = ".getfd",
+ .wsize = sizeof(struct nfsctl_fdparm),
+ .rsize = NFS_FHSIZE
+ },
+ [NFSCTL_GETFS] = {
+ .name = ".getfs",
+ .wsize = sizeof(struct nfsctl_fsparm),
+ .rsize = sizeof(struct knfsd_fh)
+ },
 };
 
 long

-- 
They that can give up essential liberty to obtain a little temporary safety
deserve neither liberty nor safety.
 -- Benjamin Franklin, Historical Review of Pennsylvania, 1759
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Art Haas: "[PATCH] C99 initializer for arch/i386/kernel/setup.c"
• Previous message: Art Haas: "[PATCH] Add small C99 named initializers to fs/bio.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:36 EST