Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390

From: Ulrich Weigand (weigand@immd1.informatik.uni-erlangen.de)
Date: Fri Feb 14 2003 - 17:30:51 EST

Next message: Andreas Steinmetz: "Re: Sparc IDE in 2.4.20"
Previous message: lkml@dm.cobite.com: "[BENCHMARK] 2.5.60-mm2+anticipatory results with Oracle db load"
Maybe in reply to: Zwane Mwaikambo: "[PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Next in thread: Zwane Mwaikambo: "Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Reply: Zwane Mwaikambo: "Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Zwane Mwaikambo wrote:

>+ cpu = get_cpu();
>+ mask &= (1UL << cpu);
>+ num_cpus = hweight32(mask);

I guess you mean
mask &= ~(1UL << cpu);
or else num_cpus is always either 0 or 1 ...

>+ for (i = 0; i < NR_CPUS; i++) {
>+ if (cpu_online(i) && ((1UL << cpu) && mask))

This should be
if (cpu_online(i) && ((1UL << i) & mask))
or else the message is sent to all online CPUs anyway ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  weigand@informatik.uni-erlangen.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Andreas Steinmetz: "Re: Sparc IDE in 2.4.20"
Previous message: lkml@dm.cobite.com: "[BENCHMARK] 2.5.60-mm2+anticipatory results with Oracle db load"
Maybe in reply to: Zwane Mwaikambo: "[PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Next in thread: Zwane Mwaikambo: "Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Reply: Zwane Mwaikambo: "Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:58 EST