Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390

From: Zwane Mwaikambo (zwane@holomorphy.com)
Date: Fri Feb 14 2003 - 21:18:09 EST

Next message: Werner Almesberger: "Re: [RFC] Migrating net/sched to new module interface"
Previous message: Max Krasnyansky: "Re: Linux v2.5.61"
In reply to: Ulrich Weigand: "Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Next in thread: Zwane Mwaikambo: "Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Reply: Zwane Mwaikambo: "Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, 14 Feb 2003, Ulrich Weigand wrote:

> Zwane Mwaikambo wrote:
>
> >+ cpu = get_cpu();
> >+ mask &= (1UL << cpu);
> >+ num_cpus = hweight32(mask);
>
> I guess you mean
> mask &= ~(1UL << cpu);
> or else num_cpus is always either 0 or 1 ...

Hmm correct

> >+ for (i = 0; i < NR_CPUS; i++) {
> >+ if (cpu_online(i) && ((1UL << cpu) && mask))
>
> This should be
> if (cpu_online(i) && ((1UL << i) & mask))
> or else the message is sent to all online CPUs anyway ...

Correct again, thanks i'll fix that.

Zwane

-- 
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Werner Almesberger: "Re: [RFC] Migrating net/sched to new module interface"
Previous message: Max Krasnyansky: "Re: Linux v2.5.61"
In reply to: Ulrich Weigand: "Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Next in thread: Zwane Mwaikambo: "Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Reply: Zwane Mwaikambo: "Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:01:00 EST