Re: more signal locking bugs?

From: Martin J. Bligh (mbligh@aracnet.com)
Date: Mon Feb 17 2003 - 00:07:06 EST


>> Ah, I see what happened, I think .... the locking used to be inside
>> collect_sigign_sigcatch, and you moved it out into task_sig ... but
>> there were two callers of collect_sigign_sigcatch, the other one being
>> proc_pid_stat
>
> Doh.
>
> This should fix it.

Don't you need this bit as well?

+ sigemptyset(&sigign);
+ sigemptyset(&sigcatch);

to replace this bit from your previous patch.

 static void collect_sigign_sigcatch(struct task_struct *p, sigset_t *ign,
                                    sigset_t *catch)
 {
        struct k_sigaction *k;
        int i;
 
- sigemptyset(ign);
- sigemptyset(catch);

That was in the patch I sent you ... but I missed task->sighand->siglock ;-)

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:16 EST