2.5.61: x86_64 num_online_cpus() buglet?

• Next message: GrandMasterLee: "Kernel bug at ll_rw_blk.c:1194"
• Previous message: Eli Carter: "Re: What language has Alan's portaloo changed to?"
• Next in thread: Andi Kleen: "Re: 2.5.61: x86_64 num_online_cpus() buglet?"
• Reply: Andi Kleen: "Re: 2.5.61: x86_64 num_online_cpus() buglet?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Andi,

Kernel 2.5.61's include/asm-x86_64/smp.h contains:

extern unsigned long cpu_online_map;
...
extern inline unsigned int num_online_cpus(void)
{
        return hweight32(cpu_online_map);
}

and similarly for cpu_callout_map.

hweight32() truncates a 64-bit operand to 32-bits, so either
- the maps should be int rather than long, or
- x86_64 needs to define and use a new hweight64(), or
- CONFIG_NR_CPUS must not exceed 32 on x86_64.

Comments?

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: GrandMasterLee: "Kernel bug at ll_rw_blk.c:1194"
• Previous message: Eli Carter: "Re: What language has Alan's portaloo changed to?"
• Next in thread: Andi Kleen: "Re: 2.5.61: x86_64 num_online_cpus() buglet?"
• Reply: Andi Kleen: "Re: 2.5.61: x86_64 num_online_cpus() buglet?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:19 EST