Re: Strange performance change 59 -> 61/62

From: Martin J. Bligh (mbligh@aracnet.com)
Date: Fri Feb 21 2003 - 12:27:29 EST


>> Some more stats ... which look rather suspicious. 600% increase for
>> dentry_open and __mark_inode_dirty? Hmmmmm.
>
> __mark_inode_dirty() just got itself an smp_mb(). Would be instructive to
> disable that.
>
> dentry_open(): don't know - fs/open.c hasn't changed at all. Perhaps
> dcache_rcu has caused additional pingpong?

2.5.59-mjb6 84 __mark_inode_dirty
2.5.61-mjb1 594 __mark_inode_dirty
2.5.61-mjb1-no_mb 74 __mark_inode_dirty

Yup, that fixed that one ... but presumably it was put there for a reason,
so I can't just rip it out ;-) Thanks, I'll go take a closer look at the
others.

M

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:34 EST