This patch fixes the incomplete data return problem of /proc/ide/hpt34x.
When the number of consecutive read bytes are smaller than the total
data in hpt34x_get_info(), the second read() returns 0.
--- linux-2.5.62-vanilla/drivers/ide/pci/hpt34x.c Sat Feb 22 23:00:40 2003
+++ linux-2.5.62/drivers/ide/pci/hpt34x.c Sat Feb 22 23:31:17 2003
@@ -58,7 +58,7 @@
static int hpt34x_get_info (char *buffer, char **addr, off_t offset, int count)
{
char *p = buffer;
- int i;
+ int i, len;
p += sprintf(p, "\n "
"HPT34X Chipset.\n");
@@ -96,7 +96,11 @@
}
p += sprintf(p, "\n");
- return p-buffer; /* => must be less than 4k! */
+ /* p - buffer must be less than 4k! */
+ len = (p - buffer) - offset;
+ *addr = buffer + offset;
+
+ return len > count ? count : len;
}
#endif /* defined(DISPLAY_HPT34X_TIMINGS) && defined(CONFIG_PROC_FS) */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:37 EST