Re: Longstanding networking / SMP issue? (duplextest)

From: Andi Kleen (ak@suse.de)
Date: Sun Feb 23 2003 - 05:30:39 EST


On Sun, Feb 23, 2003 at 01:55:11AM -0800, David S. Miller wrote:
> From: Christoph Hellwig <hch@infradead.org>
> Date: Sun, 23 Feb 2003 10:02:34 +0000
>
> On Sun, Feb 23, 2003 at 01:12:17AM -0800, David S. Miller wrote:
> > +static struct socket *__icmp_socket[NR_CPUS];
> > +#define icmp_socket __icmp_socket[smp_processor_id()]
>
> This should be per-cpu data
>
> My bad. Thanks for spotting this.

Won't work if the IPv4 code is ever made modular.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:38 EST