Re: Bug with (maybe not *in*) sysfs

From: Martin J. Bligh (mbligh@aracnet.com)
Date: Sun Feb 23 2003 - 15:33:19 EST


>> This is typically caused by the same object being added twice at the
>> same level in the hierarchy, which appears to be happening. Is the ips
>> driver calling pci_register_driver() twice?
>>
>> -pat
>
> It was possible in the past that pci_module_init could be called more
> than once with non-unique pci_driver names. It is fixed in the current
> trees, but I do not have the date when it was pushed. Here is some
> context mail links.
>
> http://marc.theaimsgroup.com/?l=linux-scsi&m=104275858704733&w=2
>
> http://marc.theaimsgroup.com/?l=linux-scsi&m=104455557710731&w=2

OK, so two similar, but not identical cards using the same driver?
First patch mentioned looks very simple, but won't apply to 2.5.62
There's now just:

   static char ips_hot_plug_name[] = "ips";

   static int __devinit ips_insert_device(struct pci_dev *pci_dev, const
struct pci_device_id *ent);
   static void __devexit ips_remove_device(struct pci_dev *pci_dev);

   struct pci_driver ips_pci_driver = {
       .name = ips_hot_plug_name,
       .id_table = ips_pci_table,
       .probe = ips_insert_device,
       .remove = __devexit_p(ips_remove_device),
   };

Second patch looks a little intimidating ... more like a full blown update
of the driver ... I'd rather not go there unless I really have to.

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:39 EST