Re: [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (6/21) FS & partiton

From: Christoph Hellwig (hch@infradead.org)
Date: Mon Feb 24 2003 - 09:16:13 EST


On Mon, Feb 24, 2003 at 11:05:39PM +0900, Osamu Tomita wrote:
> --- linux/fs/fat/inode.c 2003-01-02 12:21:53.000000000 +0900
> +++ linux98/fs/fat/inode.c 2003-02-24 11:30:10.000000000 +0900
> @@ -939,7 +939,8 @@
> error = first;
> goto out_fail;
> }
> - if (FAT_FIRST_ENT(sb, media) != first) {
> + if (FAT_FIRST_ENT(sb, media) != first
> + && (media != 0xf8 || FAT_FIRST_ENT(sb, 0xfe) != first)) {

Maybe add a small comment here describing it's needed for PC98 dos?

BTW: Linux codingstyle sais it should be written as

        if (FAT_FIRST_ENT(sb, media) != first &&
            (media != 0xf8 || FAT_FIRST_ENT(sb, 0xfe) != first)) {

Also please split this patch up into one to the fat file system
and one to the partition code.

Otherwise this patch looks nice to me.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 28 2003 - 22:00:19 EST