Re: cpufreq: allow user to specify voltage

From: Dominik Brodowski (linux@brodo.de)
Date: Mon Feb 24 2003 - 19:41:26 EST


Hi Pavel, Hi Linus,

> Hi!
>
> This allows user to specify voltage manually. This gives me 40 extra
> minutes (1h50m -> 2h30m) on HP omnibook which appears to have broken
> bios tables. Please apply,
>
> Pavel

Please don't apply this patch -- for the following reasons:
- it only uses the deprecated, overloaded cpufreq proc_intf
- selecting the voltage within the policy (minimum and maximum frequency,
  mode of operation) is not where it should be done: you may want a
  different voltage at min-speed as at max-speed. So the frequency tables,
  or -even better- the amd-k7-specific table may be a better choice for
  this.
- selecting the voltage manually is something which is only valid for some
  very few drivers - so let's only export one sysfs file[*] for these
  drivers.

        Dominik

[*] sysfs is the _only_ recommended way to access cpufreq these days.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 28 2003 - 22:00:24 EST