On Mon, Feb 24, 2003 at 11:56:10PM -0800, Andrew Morton wrote:
> Ravikiran G Thirumalai <kiran@in.ibm.com> wrote:
> >
> > This version makes the disk stats on struct gendisk per-cpu.
>
> Well OK, but it has lots of SCARY UPPER-CASE MACROS and disk_stat_inc(),
> disk_stat_dec() and disk_stat_sub() can all be defined in terms of
> disk_stat_add().
>
> I did this to it:
>
Ok, I don't have a preference one way or the other. I used upper case
since mib stats used upper case macros (it was that way before I
twiddled with it).
I'll use lower case macros for the per partition stats too.
Thanks,
Kiran
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Feb 28 2003 - 22:00:27 EST