Re: [PATCH][2.5] fix preempt-issues with smp_call_function()

From: Thomas Schlichter (schlicht@uni-mannheim.de)
Date: Wed Feb 26 2003 - 05:14:30 EST


Dave Jones <davej@codemonkey.org.uk> wrote:
> Just one comment. You moved quite a few of the preempt_disable/enable
> pairs outside of the CONFIG_SMP checks. The issue we're working against
> here is to try and prevent preemption and ending up on a different CPU.
> As this cannot happen if CONFIG_SMP=n, I don't see why you've done this.

Andrew Morton wrote:
> Just in two places.
[snip]

Yes, thanks for delivering this better patch!
My approach wanted just to be the most simple possibility... ;-)

   Thomas


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 28 2003 - 22:00:35 EST