Re: [PATCH] die kdevname(), die!

From: Christoph Hellwig (hch@lst.de)
Date: Sat Mar 01 2003 - 13:20:38 EST


On Sat, Mar 01, 2003 at 07:14:41PM +0100, Christoph Hellwig wrote:
> On Sat, Mar 01, 2003 at 10:10:23AM -0800, Linus Torvalds wrote:
> >
> > I really think that replacing "kdevname()" with "__bdevname()" is a step
> > in the wrong direction (or at least sideways).
>
> kdevname() is the really wrong interface because it doesn't know whether
> we have a character or block device. __bdevname is a bit better because
> it's block-device specific. It's not perfect yet, though.

And the actual important information is missing in this mail (I'm a bit
fast in hitting the send button today :)). The proper replacement for
kdevname on blockdevices would be partitions_name - but in this specific
case we can't use it because it's the piece of code that constructs the
name that is stored for use by partition_name if we don't have any
better information.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:16 EST