Re: [PATCH][ATM] make atm (and clip) modular + try_module_get()

From: Kai Germaschewski (kai@tp1.ruhr-uni-bochum.de)
Date: Mon Mar 03 2003 - 19:28:20 EST


On Mon, 3 Mar 2003, chas williams wrote:

> Index: linux/net/atm/Makefile
> ===================================================================
> RCS file: /home/chas/CVSROOT/linux/net/atm/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 Makefile
> --- linux/net/atm/Makefile 20 Feb 2003 13:46:30 -0000 1.1.1.1
> +++ linux/net/atm/Makefile 3 Mar 2003 16:51:03 -0000
> @@ -3,12 +3,15 @@
> #
>
> mpoa-objs := mpc.o mpoa_caches.o mpoa_proc.o
> +atm-objs := addr.o pvc.o signaling.o svc.o common.o atm_misc.o raw.o resources.o
>
> -obj-$(CONFIG_ATM) := addr.o pvc.o signaling.o svc.o common.o atm_misc.o raw.o resources.o
> +obj-$(CONFIG_ATM) += atm.o
>
> -obj-$(CONFIG_ATM_CLIP) += clip.o ipcommon.o
> -obj-$(CONFIG_NET_SCH_ATM) += ipcommon.o
> -obj-$(CONFIG_PROC_FS) += proc.o
> +obj-$(CONFIG_ATM_CLIP) += clip.o
> +# obj-$(CONFIG_NET_SCH_ATM) += ipcommon.o
> +ifeq ($(CONFIG_PROC_FS),y)
> +atm-objs += proc.o
> +endif
>
> obj-$(CONFIG_ATM_LANE) += lec.o
> obj-$(CONFIG_ATM_MPOA) += mpoa.o

Not terribly important, but you can write this as:

obj-$(CONFIG_ATM) += atm.o

atm-y += addr.o pvc.o signaling.o svc.o ...
atm-$(CONFIG_PROC_FS) += proc.o

which looks a bit nicer ;)

--Kai

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:23 EST