Re: reducing stack usage in v4l?

From: Andrew Morton (akpm@digeo.com)
Date: Wed Mar 05 2003 - 00:43:26 EST


"Randy.Dunlap" <rddunlap@osdl.org> wrote:
>
> Hi,
>
> I was looking at stack usage in drivers/media/video/v4l1-compat.c::
> v4l_compat_translate_ioctl(). It's 0x924 bytes on my peecee.
>
> It's fairly straightforward to change the stack space to
> kmalloc() space, but some of these functions (ioctls) are
> speed-critical, so I was wondering if the changes should still
> be done, or done only in some cases and not others, or wait
> until an oops is reported here....
>

Well the function is doing a memset() of 2k's worth of memory already,
so it presumably doesn't care much.

Your kmalloc will be a small cost compared with that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:27 EST