Hi!
> > +asmlinkage long compat_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg)
>
> For consistancy, this should be called compat_sys_ioctl.
Done. (And moved whole stuff to fs/compat.c).
> > +{
> > + struct file * filp;
>
> > + filp = fget(fd);
>
> > + /* find the name of the device. */
> > + if (path) {
> > + struct file *f = fget(fd);
>
> Is it really necessary to do another fget(fd) ?
This is andi's code, but it seems unneeded, fixed.
> Also, if you are adding this much code, you should add a copyright notice
> to the top of the file ...
I actually need to copy copyrights from ia32_ioctl, where I took
this. Done.
Pavel
-- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:19 EST