[2.5] memleak in drivers/scsi/cpqfcTSinit.c::cpqfcTS_ioctl

• Next message: Oleg Drokin: "Re: dpt_i2o.c fix for possibly memory corruption on reset timeout"
• Previous message: Randy.Dunlap: "Re: dpt_i2o.c fix for possibly memory corruption on reset timeout"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello!

   There seem to be a memleak on error exit path if copy_to_user() fails.
   See the patch below.

Bye,
    Oleg

===== drivers/scsi/cpqfcTSinit.c 1.32 vs edited =====
--- 1.32/drivers/scsi/cpqfcTSinit.c Tue Feb 25 21:47:18 2003
+++ edited/drivers/scsi/cpqfcTSinit.c Thu Mar 13 21:50:33 2003
@@ -686,7 +686,7 @@
         if( (vendor_cmd->rw_flag == VENDOR_READ_OPCODE) &&
              vendor_cmd->len )
         if( copy_to_user( vendor_cmd->bufp, buf, vendor_cmd->len))
- return( -EFAULT);
+ result = -EFAULT;
 
         if( buf)
           kfree( buf);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Oleg Drokin: "Re: dpt_i2o.c fix for possibly memory corruption on reset timeout"
• Previous message: Randy.Dunlap: "Re: dpt_i2o.c fix for possibly memory corruption on reset timeout"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:36 EST