Re: 2.5.64-ac3: Crash in ide_init_queue

From: Jens Axboe (axboe@suse.de)
Date: Sat Mar 15 2003 - 11:31:37 EST

On Sat, Mar 15 2003, Daniel Egger wrote:
> Am Sam, 2003-03-15 um 16.25 schrieb Daniel Egger:
>
> > > using ide tcq?
>
> > It's compiled into the kernel but unused since there's no harddrive in
> > the machine. I'll remove it from the config and retry.
>
> Nope, same problem without tcq.

Please double check, TCQ is the only way that ide_init_queue() would end
up with NULL EIP.

You could make the ide_dma_queued_on() conditional, ala:

#ifdef CONFIG_BLK_DEV_IDE_TCQ_DEFAULT
        if (HWIF(drive)->ide_dma_queued_on)
                HWIF(drive)->ide_dma_queued_on(drive);
#endif 

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:43 EST