Re: [PATCH] reduce stack in cdrom/optcd.c

From: Arjan van de Ven (arjanv@redhat.com)
Date: Sat Mar 22 2003 - 15:19:59 EST

Next message: Manfred Spraul: "Re: BUG: Use after free in detach_pid"
Previous message: Rob van Nieuwkerk: "Re: 2.4 has O_SYNC bug ?"
In reply to: Alan Cox: "Re: [PATCH] reduce stack in cdrom/optcd.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, 2003-03-22 at 21:43, Alan Cox wrote:
> On Sat, 2003-03-22 at 06:51, Randy.Dunlap wrote:
> > Hi,
> >
> > This reduces stack usage in drivers/cdrom/optcd.c by
> > dynamically allocating a large (> 2 KB) buffer.
> >
> > Patch is to 2.5.65. Please apply.
>
> This loosk broken. You are using GFP_KERNEL memory allocations on the
> read path of a block device. What happens if the allocation fails
> because we need memory

it's unlikely that you have your swap on the cdrom ;)

application/pgp-signature attachment: This is a digitally signed message part

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Manfred Spraul: "Re: BUG: Use after free in detach_pid"
Previous message: Rob van Nieuwkerk: "Re: 2.4 has O_SYNC bug ?"
In reply to: Alan Cox: "Re: [PATCH] reduce stack in cdrom/optcd.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Mar 23 2003 - 22:00:42 EST