Re: i2c-via686a driver

From: Christoph Hellwig (hch@infradead.org)
Date: Sun Mar 23 2003 - 15:27:43 EST


// The following register sets temp interrupt mode (bits 1-0 for temp1,
// 3-2 for temp2, 5-4 for temp3). Modes are:
// 00 interrupt stays as long as value is out-of-range
// 01 interrupt is cleared once register is read (default)
// 10 comparator mode- like 00, but ignores hysteresis
// 11 same as 00

        Please don't use C++-style comments in kernel code.

static inline u8 TEMP_TO_REG(long val)
{
        return (u8)
            SENSORS_LIMIT(viaLUT[((val <= -500) ? 0 : (val >= 1100) ? 160 :
                                  ((val + 5) / 10 + 50))], 0, 255);
}

        Dead code?

static int via686a_id = 0;

        This doesn't need to be initialized.

      ERROR4:

        All-uppercase is ugly..
      
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Mar 23 2003 - 22:00:45 EST