Re: current BK boot failure, d_alloc()

From: Jens Axboe (axboe@suse.de)
Date: Mon Mar 24 2003 - 12:21:06 EST

Next message: davej@codemonkey.org.uk: "fix wrong return type on parisc eisa_eeprom_llseek"
Previous message: davej@codemonkey.org.uk: "bring sparc riowatchdog in sync with 2.4"
In reply to: Randy.Dunlap: "Re: current BK boot failure, d_alloc()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Mar 24 2003, Randy.Dunlap wrote:
> > On Mon, Mar 24 2003, Jens Axboe wrote:
> >> Hi,
> >>
> >>
> [snip]
> >> craps out in memcpy() due to name->name == NULL
> >
> > smells like a compiler problem, with the following patch:
> >
> > ===== fs/dcache.c 1.43 vs edited =====
> > --- 1.43/fs/dcache.c Sat Mar 22 05:05:21 2003
> > +++ edited/fs/dcache.c Mon Mar 24 12:58:19 2003
> > @@ -784,7 +784,8 @@
> > struct dentry *res = NULL;
> >
> > if (root_inode) {
> > - res = d_alloc(NULL, &(const struct qstr) { "/", 1, 0 });
> > + struct qstr name = { .name = "/", .len = 1, .hash = 0 };
> > + res = d_alloc(NULL, &name);
> > if (res) {
> > res->d_sb = root_inode->i_sb;
> > res->d_parent = res;
> >
> > --
>
> what compiler, please?

gcc 3.3 pre-release, I cannot reproduce it in userspace though. I'll try
and take a look at the generated code.

-- Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: davej@codemonkey.org.uk: "fix wrong return type on parisc eisa_eeprom_llseek"
Previous message: davej@codemonkey.org.uk: "bring sparc riowatchdog in sync with 2.4"
In reply to: Randy.Dunlap: "Re: current BK boot failure, d_alloc()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:16 EST