On Mon, Mar 24, 2003 at 04:42:00PM +0000, davej@codemonkey.org.uk wrote:
> Sent to davem and netdev already, and was met with silence..
>
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/net/ipv4/tcp.c linux-2.5/net/ipv4/tcp.c
> --- bk-linus/net/ipv4/tcp.c 2003-03-21 12:53:31.000000000 +0000
> +++ linux-2.5/net/ipv4/tcp.c 2003-03-21 13:45:21.000000000 +0000
> @@ -1189,7 +1189,8 @@ new_segment:
>
> from += copy;
> copied += copy;
> - seglen -= copy;
> + if ((seglen -= copy) == 0 && iovlen == 0)
> + goto out;
What's the purpose of combining a statement and a test?
Simply adding a test would be more clear.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:16 EST