Re: [PATCH 1/3] revert register_chrdev_region change

From: Roman Zippel (zippel@linux-m68k.org)
Date: Mon Mar 24 2003 - 17:28:01 EST


Hi,

On Mon, 24 Mar 2003 Andries.Brouwer@cwi.nl wrote:

> > I still don't know what we need ranges or even subranges for.
> > What problem are you trying to solve?
>
> I mentioned the structure of Al's block device code to you.
> Haven't you read blk_register_region()?

I did, have you seen add_disk()? Did you notice that more drivers use
add_disk() than blk_register_region() and that most of the
blk_register_region() users are legacy drivers?
Which character device has partitions? Even for block devices it will be
easier to just define MAX_PART_NR and simply use a constant shift to get
from a partition to the disk.
Please try to keep the problem simple, all examples I've seen so far only
can be dealt with quite easily. So which problem requires a complex
(sub)ranges solution?

bye, Roman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:17 EST