On Wed, 2003-03-26 at 22:29, Greg KH wrote:
> Some of the nasty casts should be fixed up though. Stuff like:
>
> > + ERROR7:
> > + if (!is_isa)
> > + i2c_detach_client(&
> > + (((struct w83781d_data
> > + *) (i2c_get_clientdata(new_client)))->
> > + lm75[1]));
> > + ERROR6:
> > + if (!is_isa)
> > + i2c_detach_client(&
> > + (((struct w83781d_data
> > + *) (i2c_get_clientdata(new_client)))->
> > + lm75[0]));
> > + ERROR5:
> > + if (!is_isa)
> > + kfree(((struct w83781d_data *) (i2c_get_clientdata(new_client)))->
> > + lm75);
>
> Is just obnoxious :)
>
Quick question .... With sysfs, is it not needed to call
i2c_detach_client ? I am asking this as it seems from patches
that you remove all these calls ...
Regards,
--Martin Schlemmer
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:26 EST