Re: BLKGETSIZE64 is broken (0x80041272)

From: Anton Blanchard (anton@samba.org)
Date: Thu Mar 27 2003 - 22:55:20 EST


> I was adding ioctl translations and found that BLKGETSIZE64
> equals 0x80041272, with wrong size. Apparently, a whole bunch
> of ioctls takes sizeof(sizeof(foo)), which evaluates to 4
> in 32 bit userland, regardless of the size of foo.
> Are we going to do anything about it? At the bare minimum,
> I suggest we add comments near EVERY of the offenders,
> marking them as broken and warning that we are leaving them
> as is for binary compatibility. I compared 2.4 and 2.5, and
> the same breakage is present in both, only more people fell
> for this trap in 2.5, so it obviously needs some action.

Thats old news :) Check out ppc64 and sparc64 ioctl32.c, its ugly but we
have to translate them.

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:30 EST