Re: [TRIVIAL] Cleanup in fs/devpts/inode.c

From: Robert P. J. Day (rpjday@mindspring.com)
Date: Sat Mar 29 2003 - 13:36:53 EST


On Sat, 29 Mar 2003 john@grabjohn.com wrote:

> > this patch un-complicates a small piece of code of the dev/pts
> > filesystem and decreases the size of the object code by 8 bytes
> > for my build. Yay! :)
>
> > - err = PTR_ERR(devpts_mnt);
> > - if (!IS_ERR(devpts_mnt))
> > - err = 0;
> > + if (IS_ERR(devpts_mnt))
> > + err = PTR_ERR(devpts_mnt);
>
> Why not use
>
> err = (IS_ERR(devpts_mnt) ? err = 0 : PTR_ERR(devpts_mnt));

without my handy-dandy C reference book here, don't you have
that backwards?

and is there some value to using "err = 0" internally rather
than just "0"?

rday

p.s. risking major embarrassment if i didn't remember my
C programming ...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:34 EST