Re: [patch] add i2c_clients_command()

From: Gerd Knorr (kraxel@bytesex.org)
Date: Thu Apr 03 2003 - 03:49:53 EST

Next message: Petr Vandrovec: "Re: [Linux-fbdev-devel] [PATCH]: EDID parser"
Previous message: Gerd Knorr: "Re: [patch] add i2c_clientname()"
In reply to: Christoph Hellwig: "Re: [patch] add i2c_clients_command()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Christoph Hellwig <hch@infradead.org> writes:

> > +void i2c_clients_command(struct i2c_adapter *adap, unsigned int cmd, void *arg)
> > +{
> > + int i;
> > +
> > + down(&adap->list);
> > + for (i = 0; i < I2C_CLIENT_MAX; i++) {
> > + if (NULL == adap->clients[i])
> > + continue;

> This is a horrible algorithm! Please introduce a per-adapter client
> lists.

Well, I can't easily fix that single function. The whole i2c core
manages the clients that way, i.e. the whole i2c subsystem would need
a rewrite ...

Gerd

-- 
Michael Moore for president!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Petr Vandrovec: "Re: [Linux-fbdev-devel] [PATCH]: EDID parser"
Previous message: Gerd Knorr: "Re: [patch] add i2c_clientname()"
In reply to: Christoph Hellwig: "Re: [patch] add i2c_clients_command()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Apr 07 2003 - 22:00:19 EST