[PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.uni-mannheim.de: Returned mail: see transcript for details])

From: Robert Schiele (rschiele@uni-mannheim.de)
Date: Tue Apr 08 2003 - 02:18:46 EST


Hmm, vger does not like the driver name of the Adaptec driver. ;-)

Robert

----- Forwarded message from Mail Delivery Subsystem <MAILER-DAEMON@rumms.uni-mannheim.de> -----

[...]
Final-Recipient: RFC822; linux-kernel@vger.kernel.org
Action: failed
Status: 5.7.1
Remote-MTA: DNS; vger.kernel.org
Diagnostic-Code: SMTP; 550 5.7.1 The Triple-X in subject is way too often associated with junk email, please rephrase. ; S263532AbTDHGof
Last-Attempt-Date: Tue, 8 Apr 2003 08:56:12 +0200 (MEST)

Date: Tue, 8 Apr 2003 08:55:41 +0200
To: "Justin T. Gibbs" <gibbs@scsiguy.com>,
   Marcelo Tosatti <marcelo@conectiva.com.br>,
   Linus Torvalds <torvalds@transmeta.com>,
   Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Takashi Iwai <tiwai@suse.de>, Kurt Garloff <garloff@suse.de>,
   Hubert Mantel <mantel@suse.de>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] aic7xxx claims all checked EISA io ranges
User-Agent: Mutt/1.4i
From: Robert Schiele <rschiele@uni-mannheim.de>

Hello.

Some days ago a bug was introduced in aic7xxx by applying the aic7xxx driver
upgrade to both the 2.4 and the 2.5 tree. This bug makes aic7xxx to claim all
the ioport ranges that he checks while scanning for EISA cards. Takashi Iwai
and me iterated over the sources to finally find that the result value check
of the request_region() is negated.

Because of that the following patch goes to Justin to fix it in driver
development tree, to the official tree maintainers to fix it there, and to
Alan, because you sent this driver update to Marcelo, so I assume the same
problem is in your tree.

The patch applies to both, the 2.4 and the 2.5 tree.

And now for the trivial but obvious patch:

--- linux/drivers/scsi/aic7xxx/aic7770_osm.c 1 Apr 2003 19:57:24 -0000 1.4
+++ linux/drivers/scsi/aic7xxx/aic7770_osm.c 8 Apr 2003 05:37:38 -0000
@@ -66,7 +66,7 @@
                         continue;
                 request_region(eisaBase, AHC_EISA_IOSIZE, "aic7xxx");
 #else
- if (request_region(eisaBase, AHC_EISA_IOSIZE, "aic7xxx") != 0)
+ if (request_region(eisaBase, AHC_EISA_IOSIZE, "aic7xxx") == 0)
                         continue;
 #endif
 

Robert

-- 
Robert Schiele			Tel.: +49-621-181-2517
Dipl.-Wirtsch.informatiker	mailto:rschiele@uni-mannheim.de

----- End forwarded message -----

-- Robert Schiele Tel.: +49-621-181-2517 Dipl.-Wirtsch.informatiker mailto:rschiele@uni-mannheim.de


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Apr 15 2003 - 22:00:14 EST