On Sat, 12 Apr 2003 23:47:01 +0200, Pavel Machek wrote:
>This is needed otherwise APIC thinks it is not active, does not
>suspend properly, and kills machine.
This can only happen with UP if the machine boots with local
APIC enabled and the BIOS announces an MP table.
If this is the case, then yes apic_pm_activate() needs to be done.
> Extra whitespace killed (looks
>ugly). Please apply,
I think some fixes are needed first:
- You're calling apic_pm_activate() from setup_local_APIC(), which
is before its definition. This will cause a compile warning, and
a linkage error if CONFIG_PM=n.
- While calling apic_pm_activate() from setup_local_APIC() sort of
works in the UP case, it's wrong since setup_local_APIC() is called
for each CPU in SMP, and we must not run the suspend and resume
code if there is more than one CPU in the machine.
I don't have a good solution for this right now: I don't think
cpu_online_map is valid when init_lapi_devicefs() runs, and I
don't know how else to check the number of CPUs.
Changing the #ifdef CONFIG_PM block to be #if defined(CONFIG_PM)
&& !defined(CONFIG_SMP) would fix UP kernels, but SMP kernels on
UP HW would lose PM. Adding "if (num_online_cpus() > 1) return;"
to the suspend & resume procedures is ugly but should work.
/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Apr 15 2003 - 22:00:27 EST