Re: BUGed to death

From: rwhron@earthlink.net
Date: Tue Apr 15 2003 - 09:30:24 EST


The patch below eliminates 4 BUG() calls that clearly
cannot happen based on the context.

--- linux-2.5.67-mm2/fs/reiserfs/hashes.c.orig 2003-04-15 10:11:44.000000000 -0400
+++ linux-2.5.67-mm2/fs/reiserfs/hashes.c 2003-04-15 10:13:43.000000000 -0400
@@ -90,10 +90,6 @@
 
         if (len >= 12)
         {
- //assert(len < 16);
- if (len >= 16)
- BUG();
-
                 a = (u32)msg[ 0] |
                     (u32)msg[ 1] << 8 |
                     (u32)msg[ 2] << 16|
@@ -116,9 +112,6 @@
         }
         else if (len >= 8)
         {
- //assert(len < 12);
- if (len >= 12)
- BUG();
                 a = (u32)msg[ 0] |
                     (u32)msg[ 1] << 8 |
                     (u32)msg[ 2] << 16|
@@ -137,9 +130,6 @@
         }
         else if (len >= 4)
         {
- //assert(len < 8);
- if (len >= 8)
- BUG();
                 a = (u32)msg[ 0] |
                     (u32)msg[ 1] << 8 |
                     (u32)msg[ 2] << 16|
@@ -154,9 +144,6 @@
         }
         else
         {
- //assert(len < 4);
- if (len >= 4)
- BUG();
                 a = b = c = d = pad;
                 for(i = 0; i < len; i++)
                 {

-- 
Randy Hron
http://home.earthlink.net/~rwhron/kernel/bigbox.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Apr 15 2003 - 22:00:36 EST