Dave Jones wrote:
>On Tue, Apr 15, 2003 at 10:30:24AM -0400, rwhron@earthlink.net wrote:
> > The patch below eliminates 4 BUG() calls that clearly
> > cannot happen based on the context.
>
>This looks bogus.
>
> > --- linux-2.5.67-mm2/fs/reiserfs/hashes.c.orig 2003-04-15 10:11:44.000000000 -0400
> > +++ linux-2.5.67-mm2/fs/reiserfs/hashes.c 2003-04-15 10:13:43.000000000 -0400
> > @@ -90,10 +90,6 @@
> >
> > if (len >= 12)
> > {
> > - //assert(len < 16);
> > - if (len >= 16)
> > - BUG();
> > -
>
>Imagine I pass in 20. Previously, the BUG triggers. Not any more.
>Ditto the other changes. Or am _I_ missing something ?
>
Just from the context of the patch, you are right with the first
one. Subsequent bugs can be removed due to their possibility being
eliminated by previous if statements. The code suggests that
len will trivially not be >= 16 at this point, however. So the
patch is ok.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Apr 15 2003 - 22:00:36 EST