Jeff Garzik <jgarzik@pobox.com> :
[...]
> Francois Romieu wrote:
[...]
> > Jeff Garzik <jgarzik@pobox.com> :
> > [...]
> >
> >>Ok, I finally got around to attacking this one. Your patch looked ok to
> >>me until I noticed one detail:
> >>
> >> pDpa->msgbuf = kmalloc (MSG_BUF_SIZE, GFP_DMA | GFP_KERNEL);
> >>
> >>The GFP_DMA tag indicates that we can't just use pci_alloc_consistent in
> >>the normal way, as we lose the GFP_DMA designator.
> >
> >
> > Does it mean the usual pci_set_dma_mask() cooking or something more
> > elaborate ?
>
>
> Reading dma_alloc_coherent() in arch/i386/kernel/pci-dma.c, it does
> appear that would be sufficient...
I'll cook something like that then.
Anyway, I'm curious to know whether someone[1] can come with a specific mask
for this device or (even better) say that the GFP_DMA wasn't really needed in
the first place.
[1] driver claims:
** Ported to 2.1.x by Alan Cox 1998/12/9.
Any hint Mr Cox ?
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:26 EST