Re: [PATCH] new system call mknod64

From: H. Peter Anvin (hpa@zytor.com)
Date: Mon Apr 21 2003 - 01:31:18 EST


Followup to: <UTC200304202212.h3KMCIW15403.aeb@smtp.cwi.nl>
By author: Andries.Brouwer@cwi.nl
In newsgroup: linux.dev.kernel
>
> > the _right_ interface is keeping the <major, minor> tuple explicit
>
> Good! I debated with myself and changed three times between
>
> mknod64(path, mode, major, minor);
>
> and
>
> mknod64(path, mode, devhi, devlo);
>
>
> This becomes the fourth time.
>
> Andries
>
> [My choice is still unsigned int major, minor.
> Do you prefer __u32?]
>

Yes, if we are splitting it we definitely should make it __u32
(uint32_t), especially to be nice to the 64/32 platforms.

        -hpa

-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
Architectures needed: ia64 m68k mips64 ppc ppc64 s390 s390x sh v850 x86-64
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:28 EST