On Mon, Apr 21, 2003 at 03:13:31PM -0400, Ingo Molnar wrote:
> +/*
> + * Is there a way to do this via Kconfig?
> + */
> +#if CONFIG_NR_SIBLINGS_2
> +# define CONFIG_NR_SIBLINGS 2
> +#elif CONFIG_NR_SIBLINGS_4
> +# define CONFIG_NR_SIBLINGS 4
> +#else
> +# define CONFIG_NR_SIBLINGS 0
> +#endif
> +
Maybe this would be better resolved at runtime ?
With the above patch, you'd need three seperate kernel images
to run optimally on a system in each of the cases.
The 'vendor kernel' scenario here looks ugly to me.
> +#if CONFIG_NR_SIBLINGS
> +# define CONFIG_SHARE_RUNQUEUE 1
> +#else
> +# define CONFIG_SHARE_RUNQUEUE 0
> +#endif
And why can't this just be a
if (ht_enabled)
shared_runqueue = 1;
Dumping all this into the config system seems to be the
wrong direction IMHO. The myriad of runtime knobs in the
scheduler already is bad enough, without introducing
compile time ones as well.
Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:31 EST