Re: Fix irq event debug print-out, and add stack dump which can

From: Muli Ben-Yehuda (mulix@mulix.org)
Date: Tue Apr 22 2003 - 02:29:04 EST


On Tue, Apr 22, 2003 at 06:05:40AM +0000, Linux Kernel Mailing List wrote:

> printk(retval
> ? "irq event %d: bogus retval mask %x\n"
> : "irq %d: nobody cared!\n",
> irq,
> retval);

Uhm, the first printk string takes two parameters, and the second one
only one parameter... how about this cosmetic patch? Better some
superflous information than printk params mismatch. Not tested,
obvious.

diff -u -r1.31 irq.c
--- arch/i386/kernel/irq.c 21 Apr 2003 20:10:51 -0000 1.31
+++ arch/i386/kernel/irq.c 22 Apr 2003 06:31:10 -0000
@@ -225,7 +225,7 @@
                         count--;
                         printk(retval
                                 ? "irq event %d: bogus retval mask %x\n"
- : "irq %d: nobody cared!\n",
+ : "irq %d: nobody cared! (retval %x)\n",
                                 irq,
                                 retval);
                 }

-- 
Muli Ben-Yehuda
http://www.mulix.org


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:32 EST