Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()

From: Geert Uytterhoeven (geert@linux-m68k.org)
Date: Tue Apr 22 2003 - 04:46:25 EST

Next message: jw schultz: "Re: What's the deal McNeil? Bad interactive behavior in X w/ RH's 2.4.18"
Previous message: Rene Rebe: "mangled isapnp IDs in /proc/bus/isapnp/devices"
Next in thread: David S. Miller: "Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()"
Reply: David S. Miller: "Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, 20 Apr 2003, Linux Kernel Mailing List wrote:
> ChangeSet 1.1124.1.25, 2003/04/20 14:28:32-07:00, akpm@digeo.com
>
> [PATCH] use __GFP_REPEAT in pmd_alloc_one()
>
> Convert all pmd_alloc_one() implementations to use __GFP_REPEAT

If this change was bogus (cfr. Davem's checkin):

> diff -Nru a/arch/sparc/mm/sun4c.c b/arch/sparc/mm/sun4c.c
> --- a/arch/sparc/mm/sun4c.c Sun Apr 20 15:24:17 2003
> +++ b/arch/sparc/mm/sun4c.c Sun Apr 20 15:24:17 2003
> @@ -2194,7 +2194,7 @@
> BTFIXUPSET_CALL(pte_alloc_one_kernel, sun4c_pte_alloc_one_kernel, BTFIXUPCALL_NORM);
> BTFIXUPSET_CALL(pte_alloc_one, sun4c_pte_alloc_one, BTFIXUPCALL_NORM);
> BTFIXUPSET_CALL(free_pmd_fast, sun4c_free_pmd_fast, BTFIXUPCALL_NOP);
> - BTFIXUPSET_CALL(pmd_alloc_one, sun4c_pmd_alloc_one, BTFIXUPCALL_RETO0);
> + BTFIXUPSET_CALL(pmd_alloc_one, sun4c_lpmd_alloc_one, BTFIXUPCALL_RETO0);
> BTFIXUPSET_CALL(free_pgd_fast, sun4c_free_pgd_fast, BTFIXUPCALL_NORM);
> BTFIXUPSET_CALL(get_pgd_fast, sun4c_get_pgd_fast, BTFIXUPCALL_NORM);

Then this one is bogus, too:

> diff -Nru a/include/asm-m68k/sun3_pgalloc.h b/include/asm-m68k/sun3_pgalloc.h
> --- a/include/asm-m68k/sun3_pgalloc.h Sun Apr 20 15:24:17 2003
> +++ b/include/asm-m68k/sun3_pgalloc.h Sun Apr 20 15:24:17 2003
> @@ -18,7 +18,7 @@
>
> extern const char bad_pmd_string[];
>
> -#define pmd_alloc_one(mm,address) ({ BUG(); ((pmd_t *)2); })
> +#define lpmd_alloc_one(mm,address) ({ BUG(); ((pmd_t *)2); })
>
>

Gr{oetje,eeting}s,

Geert

-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: jw schultz: "Re: What's the deal McNeil? Bad interactive behavior in X w/ RH's 2.4.18"
Previous message: Rene Rebe: "mangled isapnp IDs in /proc/bus/isapnp/devices"
Next in thread: David S. Miller: "Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()"
Reply: David S. Miller: "Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:32 EST