On Wed, Apr 23, 2003 at 09:32:56AM -0400, Ben Collins wrote:
> > Can we see it please ?
>
> Stelia,
>
> http://www.linux1394.org/viewcvs/ieee1394/branches/linux-2.4
>
> Click the "Download tarball" link and replace drivers/ieee1394 with what
> you get.
Hey, that's a whole new version of ieee1394 subsystem, see below the
diffstat.
There is *NO WAY* Marcelo will accept such a patch in the -rc stage.
>From a quick reading, your version seem to do exactly the same thing
that my patch suggested (removing the spinlock around kernel_thread()),
possibly with the locking being moved to the upper layer.
Do you have a stripped down patch correcting only the outstanding issues ?
If you haven't, the choice will be either accepting my patch or
reverting your entire ieee1394 changes for the time being.
Stelian.
amdtp.c | 78 ++--
cmp.c | 70 ---
csr.c | 14
dv1394-private.h | 2
dv1394.c | 12
eth1394.c | 110 +-----
eth1394.h | 1
highlevel.c | 247 +++++++++++--
highlevel.h | 26 +
hosts.c | 68 +--
hosts.h | 21 -
ieee1394-ioctl.h | 4
ieee1394.h | 10
ieee1394_core.c | 232 +++++++++---
ieee1394_core.h | 15
ieee1394_hotplug.h | 2
ieee1394_transactions.c | 473 ++++++++++---------------
ieee1394_transactions.h | 57 ---
ieee1394_types.h | 26 +
nodemgr.c | 344 +++++++++---------
nodemgr.h | 23 -
ohci1394.c | 37 --
pcilynx.c | 119 +++++-
raw1394-private.h | 1
raw1394.c | 151 +++-----
sbp2.c | 875 +++++++++++++++++-------------------------------
sbp2.h | 149 ++------
video1394.c | 136 ++-----
video1394.h | 1
29 files changed, 1562 insertions(+), 1742 deletions(-)
-- Stelian Pop <stelian.pop@fr.alcove.com> Alcove - http://www.alcove.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:36 EST