On Thu, Apr 24, 2003 at 10:22:22AM +0530, Suparna Bhattacharya wrote:
> The task->io_wait field reflects the wait context in which
> a task is executing its i/o operations. For synchronous i/o
> task->io_wait is NULL, and the wait context is local on
> stack; for threads doing io submits or retries on behalf
> of async i/o callers, tsk->io_wait is the wait queue
> function entry to be notified on completion of a condition
> required for i/o to progress.
This is seriously wrong. Changing the behaviour of functions to depend on
a hidden parameter is bound to lead to coding errors. It is far better to
make the parameter explicite rather than implicite.
-ben
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Apr 30 2003 - 22:00:13 EST