Re: [PATCH] ieee1394.c on - compilation errors

From: Ben Collins (bcollins@debian.org)
Date: Wed Apr 30 2003 - 17:43:46 EST

Next message: James Stevenson: "Re: software reset"
Previous message: Rafael Santos: "Re: software reset"
In reply to: Grzegorz Jaskiewicz: "[PATCH] ieee1394.c on - compilation errors"
Next in thread: Grzegorz Jaskiewicz: "Re: [PATCH] ieee1394.c on - compilation errors"
Reply: Grzegorz Jaskiewicz: "Re: [PATCH] ieee1394.c on - compilation errors"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Apr 30, 2003 at 11:59:54PM +0100, Grzegorz Jaskiewicz wrote:
> Hello there!
>
> Another trivial, monkeys job patch.
>
> Anyway, it is good to look at some changes and learn :)
>

Please inspect the logic before removing things :)

I already submitted a patch to Linus to fix this. The problem is that
class_num was used as an opaque way of determining what sort of device
(host/node/unitdir) it was dealing with on the ieee1394 bus. Your patch
would likely cause a lot of oopses.

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo       - http://www.deqo.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: James Stevenson: "Re: software reset"
Previous message: Rafael Santos: "Re: software reset"
In reply to: Grzegorz Jaskiewicz: "[PATCH] ieee1394.c on - compilation errors"
Next in thread: Grzegorz Jaskiewicz: "Re: [PATCH] ieee1394.c on - compilation errors"
Reply: Grzegorz Jaskiewicz: "Re: [PATCH] ieee1394.c on - compilation errors"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Apr 30 2003 - 22:00:36 EST