Re: is there small mistake in lib/vsprintf.c of kernel 2.4.20 ?

From: Jonathan Lundell (linux@lundell-bros.com)
Date: Fri May 02 2003 - 11:52:30 EST

Next message: Martin J. Bligh: "Re: 2.5.68-mm4"
Previous message: David Mosberger: "Re: [PATCH] per-cpu change"
In reply to: Richard B. Johnson: "Re: is there small mistake in lib/vsprintf.c of kernel 2.4.20 ?"
Next in thread: Richard B. Johnson: "Re: is there small mistake in lib/vsprintf.c of kernel 2.4.20 ?"
Reply: Richard B. Johnson: "Re: is there small mistake in lib/vsprintf.c of kernel 2.4.20 ?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

At 11:27am -0400 5/2/03, Richard B. Johnson wrote:
>If your conversion chances the base to 0, you divide by 0 (not
>good) and don't get a remainder. Actually procedure number()
>protects against a base less than 2 or greater than 36 so you
>just prevent conversion altogether.

A bug in number(), looks like. (base = 0) is intended to let the
input string determine the base (16 if 0x*, else 8 if 0* else 10).
Like simple_strtol().

-- 
/Jonathan Lundell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Martin J. Bligh: "Re: 2.5.68-mm4"
Previous message: David Mosberger: "Re: [PATCH] per-cpu change"
In reply to: Richard B. Johnson: "Re: is there small mistake in lib/vsprintf.c of kernel 2.4.20 ?"
Next in thread: Richard B. Johnson: "Re: is there small mistake in lib/vsprintf.c of kernel 2.4.20 ?"
Reply: Richard B. Johnson: "Re: is there small mistake in lib/vsprintf.c of kernel 2.4.20 ?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed May 07 2003 - 22:00:16 EST