[PATCH] remove useless MOD_{INC,DEC}_USE_COUNT from sunrpc

From: Christoph Hellwig (hch@lst.de)
Date: Sun May 04 2003 - 12:14:47 EST

 - both rpciod_up and rpciod_down do a gratious inc/dec of the
   use count - but we can't ever be inside those function unless
   it's called from an other module -> totally useless
 - rpciod() (the ernel thread) also bumps the refcount when starting
   and decrements it when exiting. but as a different module must
   initiate this using rpciod_up/rpciod_down this is again not needed.
   (except when a module does rpciod_up without a matching rpciod_down -
   but that a big bug anyway and we don't need to partially handle that
   using module refcounts).

--- 1.24/net/sunrpc/sched.c Thu Mar 27 12:42:11 2003
+++ edited/net/sunrpc/sched.c Thu May 1 16:52:23 2003
@@ -952,7 +952,6 @@
         wait_queue_head_t *assassin = (wait_queue_head_t*) ptr;
         int rounds = 0;
 
- MOD_INC_USE_COUNT;
         lock_kernel();
         /*
          * Let our maker know we're running ...
@@ -995,7 +994,6 @@
 
         dprintk("RPC: rpciod exiting\n");
         unlock_kernel();
- MOD_DEC_USE_COUNT;
         return 0;
 }
 
@@ -1027,7 +1025,6 @@
 {
         int error = 0;
 
- MOD_INC_USE_COUNT;
         down(&rpciod_sema);
         dprintk("rpciod_up: pid %d, users %d\n", rpciod_pid, rpciod_users);
         rpciod_users++;
@@ -1051,7 +1048,6 @@
         error = 0;
 out:
         up(&rpciod_sema);
- MOD_DEC_USE_COUNT;
         return error;
 }
 
@@ -1060,7 +1056,6 @@
 {
         unsigned long flags;
 
- MOD_INC_USE_COUNT;
         down(&rpciod_sema);
         dprintk("rpciod_down pid %d sema %d\n", rpciod_pid, rpciod_users);
         if (rpciod_users) {
@@ -1097,7 +1092,6 @@
         spin_unlock_irqrestore(&current->sighand->siglock, flags);
 out:
         up(&rpciod_sema);
- MOD_DEC_USE_COUNT;
 }
 
 #ifdef RPC_DEBUG
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed May 07 2003 - 22:00:20 EST