Re: Fw: kernel BUG at net/core/skbuff.c:1028!

• Next message: Mohammed Sameer: "2.5.69 unresolved symbols"
• Previous message: Paul Fulghum: "Re: 2.5.69 Interrupt Latency"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <20030507.042003.26512841.davem@redhat.com> you write:
> It has to be from some of the skb linearization changes.
> I can't think of any other change we've made that would
> make this start to happen.

Yep, culprit is obvious stupid bug. This indicates a serious lack of
testing on my part 8(

Jens, does this help?
Rusty.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.69-bk2/net/ipv4/netfilter/ip_nat_core.c working-2.5.69-bk2-fix-nat/net/ipv4/netfilter/ip_nat_core.c
--- linux-2.5.69-bk2/net/ipv4/netfilter/ip_nat_core.c 2003-05-08 10:31:08.000000000 +1000
+++ working-2.5.69-bk2-fix-nat/net/ipv4/netfilter/ip_nat_core.c 2003-05-08 11:19:04.000000000 +1000
@@ -870,7 +870,8 @@ icmp_reply_translation(struct sk_buff **
            adjustment, so make sure the current checksum is correct. */
         if ((*pskb)->ip_summed != CHECKSUM_UNNECESSARY
             && (u16)csum_fold(skb_checksum(*pskb, (*pskb)->nh.iph->ihl*4,
- (*pskb)->len, 0)))
+ (*pskb)->len
+ - (*pskb)->nh.iph->ihl*4, 0)))
                 return 0;
 
         /* Must be RELATED */

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Mohammed Sameer: "2.5.69 unresolved symbols"
• Previous message: Paul Fulghum: "Re: 2.5.69 Interrupt Latency"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed May 07 2003 - 22:00:34 EST