Re: [PATCH] Use correct page protection for put_dirty_page

From: Andi Kleen (ak@muc.de)
Date: Sun May 11 2003 - 03:37:08 EST


On Sun, May 11, 2003 at 10:32:26AM +0200, Andrew Morton wrote:
> Andi Kleen <ak@muc.de> wrote:
> >
> > put_page_dirty must use the page protection of the stack VMA, not hardcoded
> > PAGE_COPY. They can be different e.g. when the stack is set non executable
> > via VM_STACK_FLAGS.
>
> OK. It seems a bit inefficient to go looking up the vma immediately after
> having created it.
>
> How about we simply pass the desired protection in to put_dirty_page()?

Fine by me.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:35 EST