Single spin_unlock path cuts this down a little..
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/kernel/rcupdate.c linux-2.5/kernel/rcupdate.c
--- bk-linus/kernel/rcupdate.c 2003-04-10 06:01:42.000000000 +0100
+++ linux-2.5/kernel/rcupdate.c 2003-04-03 06:02:38.000000000 +0100
@@ -121,9 +121,8 @@ static void rcu_check_quiescent_state(vo
{
int cpu = smp_processor_id();
- if (!test_bit(cpu, &rcu_ctrlblk.rcu_cpu_mask)) {
+ if (!test_bit(cpu, &rcu_ctrlblk.rcu_cpu_mask))
return;
- }
/*
* Races with local timer interrupt - in the worst case
@@ -134,23 +133,22 @@ static void rcu_check_quiescent_state(vo
RCU_last_qsctr(cpu) = RCU_qsctr(cpu);
return;
}
- if (RCU_qsctr(cpu) == RCU_last_qsctr(cpu)) {
+ if (RCU_qsctr(cpu) == RCU_last_qsctr(cpu))
return;
- }
spin_lock(&rcu_ctrlblk.mutex);
- if (!test_bit(cpu, &rcu_ctrlblk.rcu_cpu_mask)) {
- spin_unlock(&rcu_ctrlblk.mutex);
- return;
- }
+ if (!test_bit(cpu, &rcu_ctrlblk.rcu_cpu_mask))
+ goto out_unlock;
+
clear_bit(cpu, &rcu_ctrlblk.rcu_cpu_mask);
RCU_last_qsctr(cpu) = RCU_QSCTR_INVALID;
- if (rcu_ctrlblk.rcu_cpu_mask != 0) {
- spin_unlock(&rcu_ctrlblk.mutex);
- return;
- }
+ if (rcu_ctrlblk.rcu_cpu_mask != 0)
+ goto out_unlock;
+
rcu_ctrlblk.curbatch++;
rcu_start_batch(rcu_ctrlblk.maxbatch);
+
+out_unlock:
spin_unlock(&rcu_ctrlblk.mutex);
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:55 EST