Re: [PATCH] laptop mode, #2

• Next message: ÐÂʱ´úÍ: "(no subject)"
• Previous message: David Kastrup: "Re: Scheduling problem with 2.4?"
• In reply to: Jens Axboe: "[PATCH] laptop mode, #2"
• Next in thread: Jens Axboe: "Re: [PATCH] laptop mode, #2"
• Reply: Jens Axboe: "Re: [PATCH] laptop mode, #2"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On May 16, 2003 13:33 +0200, Jens Axboe wrote:
> + if (block_dump)
> + printk("%s: %s block %lu/%u on %s\n", current->comm, rw == WRITE ? "WRITE" : "READ", bh->b_rsector, count, kdevname(bh->b_rdev));

This should be changed to KERN_DEBUG or similar, since if you are logging
kernel messages to disk you get stuck in an infinite loop with block_dump:

kjournald: WRITE block 67416/8 on 03:05
kjournald: WRITE block 67424/8 on 03:05
kjournald: WRITE block 67432/8 on 03:05
kjournald: WRITE block 548144/8 on 03:05
kjournald: WRITE block 67440/8 on 03:05
kjournald: WRITE block 67448/8 on 03:05
kjournald: WRITE block 67456/8 on 03:05
:
:

Cheers, Andreas

--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: ÐÂʱ´úÍ: "(no subject)"
• Previous message: David Kastrup: "Re: Scheduling problem with 2.4?"
• In reply to: Jens Axboe: "[PATCH] laptop mode, #2"
• Next in thread: Jens Axboe: "Re: [PATCH] laptop mode, #2"
• Reply: Jens Axboe: "Re: [PATCH] laptop mode, #2"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri May 23 2003 - 22:00:29 EST