On Mon, 19 May 2003, Christoph Hellwig wrote:
> On Mon, May 19, 2003 at 11:38:56AM +0200, Christoph Hellwig wrote:
> > On Mon, May 19, 2003 at 10:44:46AM +0200, Jaroslav Kysela wrote:
> > > We still support the 2.2 kernel. We are trying to separate this
> > > "compatibility" code to another location, but in some cases, it is
> > > difficult. Please, make changes only for /sound/oss tree. Thank you.
> >
> > I sterongly disagree. As part of having your code in mainline you
> > have to keep it readable. Neither the compat mess nor the typedef
> > abuse help on this.
> >
>
> And it's not like the 2.2 code was actually working, e.g. the dropping
> of i_sem in ->write makes you allow multiple simultanous writes, your
> module refcounting on 2.2 is completly b0rked due to the lack of ->owner
> and many functions have change parameters..
Note we already removed 99% of compatibility code, but the remaining
pieces are very difficult to solve with C preprocesor. I know that you
do not care about older kernels, but we have good reasons to share code.
It very simplifies maintaince.
Please, let us to remove this compatibility stuff. I will probably use
one more level of preprocessing to keep the compatibility in our build
tree.
Jaroslav
-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project, SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri May 23 2003 - 22:00:33 EST