-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Rusty Russell wrote:
> 1) Overload the last futex arg (change from timeval * to void *),
> don't add YA arg at the end.
It wasn't Ingo's idea. I suggested it. Overloading parameter types is
evil. This isn't an issue anymore if the extension is implemented as a
new syscall which certainly is better.
> 2) Use __alignof__(u32) not sizeof(u32). Sure, they're the same, but
> you really mean __alignof__ here.
I would always use sizeof() in this situation. alignof is a property
the compiler can potentially relax. On x86 it could easily be defined
to 1 in case someone wants to save memory. OK, not really useful for
x86, but some embedded archs might be in such a situation. Using
sizeof() makes sure that the variable is always 4-byte aligned. For
atomic operations this certainly is a good minimal requirement.
If you want to really correct you might have to introduce something like
atomic_alignof().
- --
- --------------. ,-. 444 Castro Street
Ulrich Drepper \ ,-----------------' \ Mountain View, CA 94041 USA
Red Hat `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+yXmW2ijCOnn/RHQRAnXcAKCeYFvfkKIO/bbwqX1vUvbLkBvHKwCeN6zB
99qZZOVLMckvh6lxieUfVpY=
=LvwT
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri May 23 2003 - 22:00:38 EST