Re: Patch for strncmp use in s390 in 2.5

[Pete Zaitcev (zaitcev@redhat.com)]

>> I didn't see this posted before. Sorry if I missed it.
>> It's a harmless buglet which causes false positives with correctness
>> checking tools, and so annoys me.
> 
> Are you sure it's harmless?  Your patch changes the meaning from an
> exact match to a prefix match.  I think it's intended to be an exact
> match, but I don't know why it doesn't just use strcmp().

The buglet is harmless. Now, the fix perhaps not.
I think it may be better to replace it with strcmp, too.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/