Re: [patch] cache flush bug in mm/filemap.c (all kernels >=2.5.30(at least))

From: David S. Miller (davem@redhat.com)
Date: Wed May 28 2003 - 20:41:24 EST


From: Roman Zippel <zippel@xxxxxxxxxxxxxx>
Date: Thu, 29 May 2003 02:12:47 +0200 (CEST)

BTW it's a bit unfortunate that flush_dcache_page() is called for reads
and writes.

Please don't say it this way, this is an inaccurate description.

DMA-mapping.txt defines very precisely when flush_dcache_page() is
invoked, and that is it's only definition. I purposely DO NOT say
that "this is for reads" or "this is for handling virtual aliasing
in L1 caches", I simply define where this macro is invoked and
that is it.

Specifically, flush_dcache_page() is called any time the kernel makes
cpu stores into a page cache page that might be mapped into a user's
address space.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/